Skip to content

chore(ci): add aggregated required checks job#3321

Merged
zvolin merged 1 commit intomainfrom
zvolin/chore/required-checks
Apr 16, 2026
Merged

chore(ci): add aggregated required checks job#3321
zvolin merged 1 commit intomainfrom
zvolin/chore/required-checks

Conversation

@zvolin
Copy link
Copy Markdown
Contributor

@zvolin zvolin commented Apr 7, 2026

Adds an aggregated job for required checks. This would be the only check required in github branch settings, allowing us to control which checks are needed to pass directly from the yaml. Currently all checks need to be added by hand to the settings, requiring admin access, instead of just from a PR

@zvolin zvolin requested a review from a team April 7, 2026 16:23
@t00ts
Copy link
Copy Markdown
Contributor

t00ts commented Apr 9, 2026

Don't we have admin access anyways?

@zvolin
Copy link
Copy Markdown
Contributor Author

zvolin commented Apr 9, 2026

I mean, this is not strictly needed, but after manually typing all job names to required checks I thought it's nice to have. Admin access comes and goes + this is declarative and makes required stuff reviewable. No hard feelings however

Copy link
Copy Markdown
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zvolin zvolin merged commit d44a8f2 into main Apr 16, 2026
11 checks passed
@zvolin zvolin deleted the zvolin/chore/required-checks branch April 16, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants